Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add test for issue 55500 and it has been fixed by #53489 #55503

Merged
merged 1 commit into from
Aug 19, 2024
Merged

executor: add test for issue 55500 and it has been fixed by #53489 #55503

merged 1 commit into from
Aug 19, 2024

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Aug 19, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #55500

Problem Summary: As title said.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Aug 19, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2024
@tiprow tiprow
Copy link

tiprow bot commented Aug 19, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@crazycs520 crazycs520 removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 19, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-19 09:44:19.18403738 +0000 UTC m=+172254.318487500: ☑️ agreed by D3Hunter.
  • 2024-08-19 10:01:56.282143097 +0000 UTC m=+173311.416593219: ☑️ agreed by zyguan.

@ti-chi-bot ti-chi-bot bot merged commit 45b127d into pingcap:master Aug 19, 2024
12 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 19, 2024
@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#55503
d59cbea 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55504.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 19, 2024
Merged
13 tasks
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7870%. Comparing base (f751f73) to head (6f644e0).
Report is 175 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #55503        +/-   ##
================================================
+ Coverage   72.9184%   74.7870%   +1.8685%     
================================================
  Files          1576       1576                
  Lines        440806     440844        +38     
================================================
+ Hits         321429     329694      +8265     
+ Misses        99636      90931      -8705     
- Partials      19741      20219       +478
Flag Coverage Δ
integration 49.1806% <ø> (?)
unit 71.8773% <ø> (-0.1170%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5096% <ø> (+6.5157%) ⬆️

ti-chi-bot bot pushed a commit that referenced this pull request Aug 19, 2024
@ti-chi-bot
executor: add test for issue 55500 and it has been fixed by #53489 (#…
23c1352 
…55503) (#55504)

ref #55500
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 26, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 26, 2024
@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#55503
4b9bbe4 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55642.

crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Aug 26, 2024
@crazycs520
executor: add test for issue 55500 and it has been fixed by pingcap#5…
8c7e495 
…3489 (pingcap#55503)

Signed-off-by: crazycs520 <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 27, 2024
@ti-chi-bot
executor: add test for issue 55500 and it has been fixed by #53489 (#…
5cbe32a 
…55503) (#55642)

ref #55500
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 12, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 12, 2024
@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#55503
ba7eaf0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56048.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 12, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Sep 12, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 12, 2024
@crazycs520 @ti-chi-bot
This is an automated cherry-pick of pingcap#55503
8104f90 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56049.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 12, 2024
Merged
13 tasks
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@crazycs520
Revert "This is an automated cherry-pick of pingcap#55503"
02c504d 
This reverts commit 8104f90.
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@crazycs520
executor: add test for issue 55500 and it has been fixed by pingcap#5…
7525ed9 
…3489 (pingcap#55503)

Signed-off-by: crazycs520 <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@ti-chi-bot
executor: add test for issue 55500 and it has been fixed by #53489 (#…
20ad05f 
…55503) (#56049)

ref #55500
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@ti-chi-bot
executor: add test for issue 55500 and it has been fixed by #53489 (#…
a5cdc08 
…55503) (#56048)

ref #55500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @ti-chi-bot @D3Hunter @zyguan